This repository has been archived by the owner on Aug 28, 2023. It is now read-only.
Remove individual foreign key requests for city view #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fungjj92
changed the title
ddohler
pushed a commit
that referenced
this pull request
Aug 21, 2023
Remove individual foreign key requests for city view
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Thanks to the fancy new Django Toolbar, Reed discovered the city endpoint was creating a SQL request for the map cell associated to each city. This rolls it all into the 1 database query.
Notes
There were no other found instances when testing all other endpoints. Note the false positive in the issue.
Checklist
Closes #523