Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use built-in JSONField #16

Closed
wants to merge 2 commits into from
Closed

Use built-in JSONField #16

wants to merge 2 commits into from

Conversation

jeancochrane
Copy link

@jeancochrane jeancochrane commented Jul 23, 2018 •
edited
Loading

Overview

This PR demonstrates the changes I had to make in order to move this package over to the built-in JSONField type. I'm opening it for diff purposes only -- I don't intend to bring these changes in.

Notes

  • Since this PR is for diff purposes only, I'll close it once its parent PR comes in.

Testing

Run unit tests according to the instructions in the README:

# Build containers.
docker-compose build

# Run tests.
docker-compose run --rm test

@jeancochrane jeancochrane mentioned this pull request Jul 23, 2018
Merged
@ddohler
Copy link
Contributor

ddohler commented Jul 30, 2018

Looks like the parent has been closed, can this be deleted now?

@jeancochrane
Copy link
Author

jeancochrane commented Jul 30, 2018 •
edited
Loading

Yup, thanks for catching that @ddohler!

@jeancochrane jeancochrane deleted the use-builtin-jsonfield branch July 30, 2018 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeancochrane @ddohler