Include path fragment in open api spec and routes #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jisantuc
commented
Jun 25, 2021
| @@ -134,10 +142,8 @@ $$$$ | |||
| ).routes | |||
| landingPageRoutes = new LandingPageService[IO](apiConfig).routes | |||
| router = CORS( | |||
| Router( | |||
There was a problem hiding this comment.
Router can be used to map different services on different endpoints, but tapir is already doing that for us with the endpoint definitions / http4s interpreter, so we can unindent
| ).endpoints ++ landingPage.endpoints | ||
| docs = allEndpoints.toOpenAPI("Franklin", "0.0.1") | ||
| docs = OpenAPIDocsInterpreter.toOpenAPI(allEndpoints, "Franklin", "0.0.1") |
There was a problem hiding this comment.
Get rid of a deprecation that's been annoying but unimportant for a while
|
Gonna go ahead and 🤠 this in since I'm out all of next week |
pomadchin
reviewed
Jun 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR makes it so that the API path fragment is respected everywhere. It accomplishes this through a helper method that takes an optional path prefix and the base path and builds a new endpoint input out of both.
Checklist
New tests have been added or existing tests have been modifiedTesting Instructions
/stac/api,stac/api, andstac/api/--api-pathargumentshttp :9090/stac/api/collectionswith each of them:9090/open-api/spec.yamlfor each of them--with-tilesand--with-transactionsCloses #779 (if applicable)