disallow non-finite Box coords

azavea · Oct 10, 2024 · 1ca6357 · 1ca6357
1 parent 10a9c98
commit 1ca6357
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/rastervision_core/rastervision/core/box.py b/rastervision_core/rastervision/core/box.py
@@ -40,6 +40,10 @@ def __init__(self, ymin: int, xmin: int, ymax: int, xmax: int):
             ymax: maximum y value
             xmax: maximum x value
         """
+        if not all(math.isfinite(v) for v in (ymin, xmin, ymax, xmax)):
+            raise ValueError(
+                f'Invalid Box coordinates: {(ymin, xmin, ymax, xmax)}.')
+
         self.ymin = ymin
         self.xmin = xmin
         self.ymax = ymax

diff --git a/tests/core/test_box.py b/tests/core/test_box.py
@@ -443,6 +443,11 @@ def test_in(self):
         with self.assertRaises(NotImplementedError):
             _ = '' in Box(0, 0, 1, 1)
 
+    def test_error_on_nonfinite_inputs(self):
+        self.assertRaises(ValueError, lambda: Box(np.inf, 0, 0, 0))
+        self.assertRaises(ValueError, lambda: Box(-np.inf, 0, 0, 0))
+        self.assertRaises(ValueError, lambda: Box(np.nan, 0, 0, 0))
+
 
 if __name__ == '__main__':
     unittest.main()