Fix inconsistent handling of RasterSourceConfig.bbox
's type
#1899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR makes it so that
RasterSourceConfig.bbox
is always a tuple, to allow it to be serialized and deserialized by pydantic.Motivation: previously,
RasterSourceConfig.bbox
was defined as a tuple in theRasterSourceConfig
definition, but was automatically converted to aBox
in its pydantic validator. This meant that although the field could be initialized as aBox
, it could not be serialized by pydantic. This was not caught in the integration tests, because none of them use thebbox
field.The error can be reproduced by e.g. adding
bbox=(0, 0, 328, 1342)
toRasterioSourceConfig
thechip_classification.basic
integration test.Checklist
needs-backport
label if PR is bug fix that applies to previous minor releaseNotes
This PR is an alternative to #1895.
Testing Instructions
chip_classification.basic
integration test runs withbbox=(0, 0, 328, 1342)
added toRasterioSourceConfig
.