Add scripts for building packages and publishing them to PyPi #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdeelH
added
the
needs-backport
AdeelH
changed the title
AdeelH
force-pushed
the
automate_pypi_publish
branch
from
0d96cf7 to
490a3a6
Compare
|
@AdeelH 👀 |
jamesmcclain
approved these changes
Sep 13, 2023
| @@ -0,0 +1,27 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
I don't see anything that looks obviously wrong to me ... if the test publication works as expected, than it should be good.
| for plugin in "${plugins[@]}"; do | ||
| publish_plugin "$plugin" | ||
| done | ||
|
|
There was a problem hiding this comment.
The only thing that I might suggest -- from a belt-and-suspenders point of view -- is to force a test publication before a real one. If the person says passes --test then it will terminate after the test publication, if they do not then it will publish to testpypi then prompt them to inspect the published artifacts before proceeding with the real publication.
There was a problem hiding this comment.
To keep things simple, I've made it so that
--testworks as before- With no
--test, you have to go through anActually publish to PyPi? (y/N)prompt -ybypasses the prompt (for when/if we choose to fully automate things)
AdeelH
force-pushed
the
automate_pypi_publish
branch
from
dd9123e to
e53b464
Compare
AdeelH
added a commit
to AdeelH/raster-vision
that referenced
this pull request
Sep 22, 2023
…#1915) * add pypi_build and pypi_publish scripts * update release instructions --------- Co-authored-by: Adeel Hassan <ahassan@element84.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds scripts to build and publish packages to PyPi, thus automating a manual and tedious part of the release process. It also updates the release instructions accordingly.
This PR is a step towards #1130.
Checklist
needs-backportlabel if PR is bug fix that applies to previous minor releaseTesting Instructions