Use smarter default padding value for sliding windows #2190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces a new
calculate_required_padding()
function that calculates the appropriate padding size--based onsize
,stride
,pad_direction
, andcrop_sz
--which is now used byBox.get_windows()
andpredict_scene_ss()
. It also adds more discussion about padding to the Sampling training data tutorial notebook.The main motivation is to make it easier to determine the right padding when making semantic segmentation predictions with a
crop_sz
such that no pixels are left out. The padding value calculated bycalculate_required_padding()
ensures this.Additionally, when
crop_sz
is not specified,calculate_required_padding()
returns the minimum padding required to generate enough windows to cover the entire extent. This is a change from the previous behavior of always usingsize / 2
.Checklist
needs-backport
label if the change should be back-ported to the previous releaseNotes
N/A
Testing Instructions
See new/updated unit tests.