Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. type fixes and improvements #2210

Merged
merged 5 commits into from
Aug 5, 2024
Merged

Conversation

AdeelH
Copy link
Collaborator

@AdeelH AdeelH commented Aug 5, 2024

Overview

This PR makes various type-related fixes and improvements, plus some minor refactoring. It also adds py.typed files.

Checklist

  • Added unit tests, if applicable
  • Updated documentation, if applicable
  • Added needs-backport label if the change should be back-ported to the previous release
  • PR has a name that won't get you publicly shamed for vagueness

Notes

Some of the problems fixed by this PR were surfaced by mypy, but it should be noted that the full codebase is not yet fully mypy-approved.

Testing Instructions

N/A

@AdeelH AdeelH marked this pull request as ready for review August 5, 2024 15:17
@AdeelH AdeelH merged commit d5e3b1c into azavea:master Aug 5, 2024
2 checks passed
@AdeelH AdeelH deleted the type_hint_fixes branch August 13, 2024 13:57
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.19%. Comparing base (8ab5837) to head (1597673).
Report is 38 commits behind head on master.

Files with missing lines Patch % Lines
...ision_aws_s3/rastervision/aws_s3/s3_file_system.py 80.00% 1 Missing ⚠️
...n/core/rv_pipeline/semantic_segmentation_config.py 50.00% 1 Missing ⚠️
rastervision_pipeline/rastervision/pipeline/cli.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2210      +/-   ##
==========================================
- Coverage   90.27%   90.19%   -0.08%     
==========================================
  Files         198      198              
  Lines        9902     9896       -6     
==========================================
- Hits         8939     8926      -13     
- Misses        963      970       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant