Restore compatibility with python<3.11 by only importing typing.Self under if TPYE_CHECKING
#2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typing.Self is only available in python >=3.11, so this makes the codebase compatible with earlier python versions again
AdeelH
added
the
needs-backport
AdeelH
changed the title
typing.Self under TPYE_CHECKINGtyping.Self under if TPYE_CHECKING
AdeelH
added a commit
to AdeelH/raster-vision
that referenced
this pull request
Aug 29, 2024
typing.Self is only available in python >=3.11, so this makes the codebase compatible with earlier python versions again
AdeelH
added a commit
that referenced
this pull request
Aug 30, 2024
typing.Self is only available in python >=3.11, so this makes the codebase compatible with earlier python versions again
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2221 +/- ##
=======================================
Coverage 90.34% 90.34%
=======================================
Files 199 199
Lines 9910 9910
=======================================
Hits 8953 8953
Misses 957 957 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
typing.Selfis only available in python>=3.11. v0.31.1 therefore broke compatibility with earlier python versions by making use of it in type hints. This PR moves the import oftyping.Selftoif TYPE_CHECKINGblocks to fix that.Checklist
needs-backportlabel if the change should be back-ported to the previous releaseNotes
N/A
Testing Instructions
N/A