Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Summer Package refresh 2020 #50

Merged
merged 4 commits into from
Jul 22, 2020
Merged

Summer Package refresh 2020 #50

merged 4 commits into from
Jul 22, 2020

Conversation

AdrieanKhisbe
Copy link
Collaborator

@AdrieanKhisbe AdrieanKhisbe commented Jul 20, 2020 •
edited
Loading

Batch of package updates

Replace #47, #48, #49 and #51

@AdrieanKhisbe AdrieanKhisbe added the dependencies Pull requests that update a dependency file label Jul 20, 2020
@AdrieanKhisbe AdrieanKhisbe requested a review from azeemba July 20, 2020 20:43
@AdrieanKhisbe AdrieanKhisbe self-assigned this Jul 20, 2020
azeemba
azeemba reviewed Jul 20, 2020
View reviewed changes
Copy link
Owner

@azeemba azeemba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like mocha doesn't support Node8.
Should we remove Node8 from the tests? Or should we stick with the older mocha?

@AdrieanKhisbe
Copy link
Collaborator Author

@azeemba Ooops, little oversight from my side.

I think we should land this refresh with node 8 support,

but then on the long term I'm not sure yet we should drop node8 on short notice:

  • it is so far only induced by devDependencies
  • it would imply dropping support of eslint:6

(then would come question if we should drop 🎱 before addressing #39 and #37)

@AdrieanKhisbe AdrieanKhisbe force-pushed the package-refresh-2020-summer branch from 5a54f47 to aa5c9ba Compare July 21, 2020 06:29
@AdrieanKhisbe
Copy link
Collaborator Author

(rebased to downgrade mocha to keep node 8 support)

azeemba
azeemba approved these changes Jul 21, 2020
View reviewed changes
Copy link
Owner

@azeemba azeemba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

Once this is merged, I will push out a release.

@AdrieanKhisbe AdrieanKhisbe merged commit 10a1cac into azeemba:master Jul 22, 2020
@AdrieanKhisbe AdrieanKhisbe deleted the package-refresh-2020-summer branch July 22, 2020 06:01
@AdrieanKhisbe
Copy link
Collaborator Author

Et voilà :)

IMO, considering changes, a patch would do. (v2.1.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeemba azeemba azeemba approved these changes

Assignees

@AdrieanKhisbe AdrieanKhisbe

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdrieanKhisbe @azeemba