Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset options list to initial state when search input is cleared #98

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

kofiarkoh
Copy link
Collaborator

Description

This address the the challenge of search options remaining the same even after clearing the search box. Ideally, the options should be reset to the default list after the search box is cleared.

Fixes # (issue)
See Related Issue: #96

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

This is has been manually tested on android 14

Test Configuration:

  • Firmware version:
  • Hardware: Samsung Device
  • Toolchain:
  • SDK: android 14

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

github-actions bot commented Dec 2, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
97.35% (+0.03% 🔼)
257/264
🟢 Branches 94.57% 174/184
🟢 Functions
95.28% (+0.04% 🔼)
101/106
🟢 Lines
97.67% (+0.03% 🔼)
252/258

Test suite run success

26 tests passing in 3 suites.

Report generated by 🧪jest coverage report action from 0db344e

@kofiarkoh kofiarkoh mentioned this pull request Dec 2, 2024
8 tasks
@azeezat
Copy link
Owner

azeezat commented Dec 15, 2024

Looks great! Thanks for addressing this issue.

@azeezat azeezat merged commit e39c8be into main Dec 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants