Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Scripts/Naxxramas): refactored instance script #21539

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Razor2142
Copy link
Contributor

@Razor2142 Razor2142 commented Feb 19, 2025

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

  • Fixed Grobbulus gate state when in progress.
  • Fixed Kel'Thuzad RP dialog when Mr. Bigglesworth is killed.

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added DB related to the SQL database Script file-cpp Used to trigger the matrix build labels Feb 19, 2025
@Razor2142 Razor2142 force-pushed the naxx-instance-refactor branch from 860c941 to cad7064 Compare February 20, 2025 08:41
@Nyeriah
Copy link
Member

Nyeriah commented Feb 20, 2025

Looks good, I'm just not sure about moving the loading of the script files away from the loader file

@Razor2142 Razor2142 force-pushed the naxx-instance-refactor branch 2 times, most recently from 9d188ea to c02c875 Compare February 20, 2025 18:20
@Razor2142
Copy link
Contributor Author

@Nyeriah Feels cleaner to have the instance self contained but I can revert it.

@Razor2142 Razor2142 force-pushed the naxx-instance-refactor branch 4 times, most recently from 32650f1 to f1b0e61 Compare February 20, 2025 18:40
@Razor2142 Razor2142 force-pushed the naxx-instance-refactor branch from f1b0e61 to a081541 Compare February 20, 2025 18:46
@Nyeriah
Copy link
Member

Nyeriah commented Feb 21, 2025

Feels cleaner to have the instance self contained but I can revert it.

It would make the review process faster without it, as I am not certain that is something we want at this time as it wouldn't be consistent with the rest of the code. So if you could keep that as it was, I think I am ready to green light this. We could, of course, always come back to that in another PR, if we decide we are up to changing all other instances too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB related to the SQL database file-cpp Used to trigger the matrix build Script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants