Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-20280] feat: add edge application do publish #125

Merged
merged 4 commits into from
May 10, 2022
Merged

[ENG-20280] feat: add edge application do publish #125

merged 4 commits into from
May 10, 2022

Conversation

PatrickMenoti
Copy link
Collaborator

@PatrickMenoti PatrickMenoti commented May 9, 2022 •
edited by jira bot
Loading

WHAT
Add Edge Application to publish command, including the addition of a Function Instance.

WHAT
ENG-20280

@PatrickMenoti PatrickMenoti self-assigned this May 9, 2022
@PatrickMenoti PatrickMenoti requested a review from a team May 9, 2022 18:08
@github-actions
Copy link

github-actions bot commented May 9, 2022 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

PatrickMenoti
PatrickMenoti commented May 9, 2022
View reviewed changes
Copy link
Collaborator Author

@PatrickMenoti PatrickMenoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have read the CLA Document and I hereby sign the CLA

PatrickMenoti
PatrickMenoti commented May 9, 2022
View reviewed changes
Copy link
Collaborator Author

@PatrickMenoti PatrickMenoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recheck

@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2022
@aziontech aziontech unlocked this conversation May 10, 2022
fmiamoto
fmiamoto approved these changes May 10, 2022
View reviewed changes
pkg/cmd/publish/publish.go Outdated Show resolved Hide resolved
PatrickMenoti
PatrickMenoti commented May 10, 2022
View reviewed changes
Copy link
Collaborator Author

@PatrickMenoti PatrickMenoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have read the CLA Document and I hereby sign the CLA

@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2022
@aziontech aziontech unlocked this conversation May 10, 2022
@PatrickMenoti PatrickMenoti merged commit a9f3533 into dev May 10, 2022
@PatrickMenoti PatrickMenoti deleted the application-publish branch May 10, 2022 17:50
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cmarques7 cmarques7 cmarques7 approved these changes

@askazion askazion askazion approved these changes

@fmiamoto fmiamoto fmiamoto approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PatrickMenoti @cmarques7 @askazion @fmiamoto @AndreSilveiraAzion