Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change listing and unit test #321

Merged
merged 1 commit into from
Mar 3, 2023
Merged

chore: change listing and unit test #321

merged 1 commit into from
Mar 3, 2023

Conversation

PatrickMenoti
Copy link
Collaborator

WHAT

  • Active as last field in listing, to follow the convention;
  • Unit test for checkOrderField.

@PatrickMenoti PatrickMenoti requested a review from a team March 3, 2023 13:12
@PatrickMenoti PatrickMenoti self-assigned this Mar 3, 2023
peterpaulo-azion
peterpaulo-azion approved these changes Mar 3, 2023
View reviewed changes
Copy link

@peterpaulo-azion peterpaulo-azion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PatrickMenoti PatrickMenoti merged commit 3e50ea7 into dev Mar 3, 2023
@PatrickMenoti PatrickMenoti deleted the small-improvements branch March 3, 2023 13:56
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@peterpaulo-azion peterpaulo-azion peterpaulo-azion approved these changes

@maxwelbm maxwelbm maxwelbm approved these changes

@ftoldato ftoldato ftoldato approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PatrickMenoti @ftoldato @maxwelbm @peterpaulo-azion