Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: read info.json instead of .vulcan #952

Merged
merged 2 commits into from
Sep 17, 2024
Merged

chore: read info.json instead of .vulcan #952

merged 2 commits into from
Sep 17, 2024

Conversation

PatrickMenoti
Copy link
Collaborator

@PatrickMenoti PatrickMenoti commented Sep 16, 2024 •
edited
Loading

This file will be removed from future versions, so I'm just removing this dependency now.

@PatrickMenoti PatrickMenoti self-assigned this Sep 16, 2024
@PatrickMenoti PatrickMenoti requested a review from a team as a code owner September 16, 2024 14:17
@PatrickMenoti PatrickMenoti added the refactor code improvement or code simplification, anything to do with sweeping up dirt label Sep 16, 2024
maxwelbm
maxwelbm approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@maxwelbm maxwelbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@PatrickMenoti PatrickMenoti merged commit cad0af3 into dev Sep 17, 2024
4 checks passed
@PatrickMenoti PatrickMenoti deleted the read-info-json branch September 17, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigomaria rodrigomaria rodrigomaria approved these changes

@maxwelbm maxwelbm maxwelbm approved these changes

Assignees

@PatrickMenoti PatrickMenoti

Labels
refactor code improvement or code simplification, anything to do with sweeping up dirt
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PatrickMenoti @rodrigomaria @maxwelbm