Style and include fixes #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azreika
approved these changes
May 21, 2019
| @@ -478,7 +478,7 @@ class AstRecordInit : public AstArgument { | |||
| public: | |||
| AstRecordInit() = default; | |||
|
|
|||
| AstRecordInit(const AstTypeIdentifier& type) : type(type) {} | |||
| AstRecordInit(AstTypeIdentifier type) : type(std::move(type)) {} | |||
There was a problem hiding this comment.
Why is this preferred? Just better style or?
|
Thanks for this! |
azreika
pushed a commit
that referenced
this pull request
Dec 8, 2020
…factor Index analysis refactor #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I've spent way too much time in the past filtering out the less useful iwyu includes...
Also added a fix so it compiles after the merge.