Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support interruptible streaming #16

Merged
merged 34 commits into from
Nov 27, 2023
Merged

Support interruptible streaming #16

merged 34 commits into from
Nov 27, 2023

Conversation

azriel91
Copy link
Owner

@azriel91 azriel91 commented Nov 8, 2023

No description provided.

@azriel91
Pass Interruptibility to fn_ready_queuer.
a1e5df6
@azriel91
Add try_for_each_concurrent_interruptible.
153e5af
@azriel91
Update try_for_each_concurrent_* to return FnGraphStreamOutcome.
09318c7
@azriel91
Replace try_stream _rev functions to _with and take in opts.
f69f2b5
@azriel91
Flip opts and fn_try_for_each arguments around.
1e36b6f
@azriel91
Extract stream_setup_init code to reduce duplication.
d9c55d9
@azriel91
Refactor stream_internal to commonize stream initialization code.
a0e4161
@azriel91
Rename fold_rev_async to fold_async_rev.
f027732
@azriel91
Change fold_async* to return FnGraphStreamOutcome.
51ea7ac
@azriel91
Update for_each_concurrent* to return FnGraphStreamOutcome.
b1a0df3
@azriel91
Address clippy lints.
4e4e856
@azriel91
Rename FnGraphStreamOutcome to StreamOutcome.
9a27506
@azriel91
Rename FnGraphStreamOpts to StreamOpts.
e047ffb
@azriel91
Rename FnGraphStreamProgress to StreamProgress.
66529a5
@azriel91
Rename FnGraphStreamOutcomeState to StreamOutcomeState.
a65ae9c
@azriel91
Rename FnGraphStreamProgressState to StreamProgressState.
e4e9807
@azriel91
Extract common logic in streaming functions.
c8dd032
@azriel91
Change stream_rev to stream_with and return PollOutcome<_>.
081a03c
@azriel91
Remove unnecessary Option layer around fold_async_with.
a23316b
@azriel91
Add try_fold_async_with.
0c14692
@azriel91
Provide separate function for *fold_async* and *fold_async_mut*.
bd2a8a8
@azriel91
Remove unnecessary lifetime annotations.
3eb0d87
@azriel91
Reduce FnMut bound to Fn in *fold_async*.
71b0af8
@azriel91
Wrap *fold_async* F parameter in FnWrappers to upper bind lifet…
b9c0d29 
…imes.

See <https://users.rust-lang.org/t/102064> for issue.
@azriel91
Address clippy lints.
6d1b416
@azriel91
Add documentation to FnGraph::stream_with to refer consumers to `*f…
b1a422b 
…old_async_with`.
@azriel91
Add StreamOutcome::replace.
072dade
@azriel91
Add documentation to StreamOutcomeState::NotStarted.
3d6add8
@azriel91
[no ci] Swap path patch for git patch.
283199a
@azriel91
Revert "[no ci] Swap path patch for git patch."
5de22a6 
This reverts commit 283199a.
@azriel91 azriel91 marked this pull request as ready for review November 27, 2023 19:40
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2023 •
edited
Loading

Codecov Report

Attention: 77 lines in your changes are missing coverage. Please review.

Comparison is base (3f9328d) 98.40% compared to head (79164ab) 96.72%.

Files Patch % Lines
src/stream_outcome.rs 54.80% 47 Missing ⚠️
src/stream_progress.rs 24.24% 25 Missing ⚠️
src/fn_wrapper_mut.rs 75.00% 3 Missing ⚠️
src/stream_opts.rs 93.75% 1 Missing ⚠️
src/stream_order.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   98.40%   96.72%   -1.68%     
==========================================
  Files          13       19       +6     
  Lines        3501     4513    +1012     
==========================================
+ Hits         3445     4365     +920     
- Misses         56      148      +92

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azriel91 azriel91 merged commit fe1ed03 into main Nov 27, 2023
10 checks passed
@azriel91 azriel91 deleted the feature/interruptible-stream branch November 27, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@azriel91