Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include entry for current and discovered states, and diff in app_cycle example. #105

Merged
merged 16 commits into from
Mar 24, 2023

Conversation

azriel91
Copy link
Owner

Closes #91 -- though this is handled at the application level, not by the framework.

  • Include entry for current and discovered states, and diff in app_cycle example.
  • Sort progress bars based on insertion order.
  • Use and parallelogram characters for progress bars.
  • Spinner progress is now rendered.

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Patch coverage: 68.39% and project coverage change: -0.12 ⚠️

Comparison is base (854c8aa) 93.47% compared to head (36ee243) 93.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   93.47%   93.35%   -0.12%     
==========================================
  Files         276      273       -3     
  Lines       20497    20669     +172     
==========================================
+ Hits        19159    19296     +137     
- Misses       1338     1373      +35     
Impacted Files Coverage Δ
crate/fmt/src/presentable.rs 100.00% <ø> (ø)
crate/fmt/src/presentable/tuple_impl.rs 100.00% <ø> (+90.74%) ⬆️
crate/rt_model/src/in_memory_text_output.rs 44.44% <0.00%> (ø)
workspace_tests/src/fn_tracker_presenter.rs 33.01% <0.00%> (-7.68%) ⬇️
workspace_tests/src/no_op_output.rs 44.44% <0.00%> (ø)
...ate/rt_model_native/src/output/cli_md_presenter.rs 71.84% <20.68%> (-24.08%) ⬇️
crate/rt_model_native/src/output/cli_output.rs 86.70% <88.96%> (+1.88%) ⬆️
crate/code_gen/src/cmd/impl_build.rs 99.37% <100.00%> (ø)
crate/rt/src/cmds/sub/apply_cmd.rs 78.12% <100.00%> (+1.86%) ⬆️
...ate/rt/src/cmds/sub/states_current_discover_cmd.rs 97.22% <100.00%> (-0.15%) ⬇️
... and 7 more

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@azriel91 azriel91 force-pushed the feature/91/states-include-entry-for-each-item-spec branch from af70c15 to 3a5596e Compare March 24, 2023 02:40
@azriel91 azriel91 merged commit 52de57d into main Mar 24, 2023
@azriel91 azriel91 deleted the feature/91/states-include-entry-for-each-item-spec branch March 24, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant