Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split FlowParams and ItemSpecParams #117

Merged
merged 41 commits into from
Apr 22, 2023

Conversation

azriel91
Copy link
Owner

Closes #116.

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch coverage: 89.69% and project coverage change: -0.47 ⚠️

Comparison is base (e25143d) 92.40% compared to head (1fdc545) 91.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
- Coverage   92.40%   91.94%   -0.47%     
==========================================
  Files         277      288      +11     
  Lines       20981    22298    +1317     
==========================================
+ Hits        19387    20501    +1114     
- Misses       1594     1797     +203     
Impacted Files Coverage Δ
crate/core/src/apply_check.rs 100.00% <ø> (ø)
crate/core/src/lib.rs 100.00% <ø> (ø)
crate/core/src/progress/progress_status.rs 100.00% <ø> (ø)
crate/resources/src/paths.rs 100.00% <ø> (ø)
crate/resources/src/resources.rs 100.00% <ø> (ø)
crate/resources/src/states/states_saved.rs 100.00% <ø> (ø)
crate/rt_model/src/states_type_reg.rs 100.00% <ø> (ø)
crate/rt_model_core/src/error.rs 2.00% <0.00%> (-31.34%) ⬇️
item_specs/sh_cmd/src/cmd_variant.rs 0.00% <0.00%> (ø)
item_specs/sh_cmd/src/sh_cmd_data.rs 25.00% <ø> (-32.15%) ⬇️
... and 67 more

... and 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@azriel91 azriel91 force-pushed the feature/116/split-flow-params-and-item-spec-params branch from fcc82ba to ec07f33 Compare April 16, 2023 22:07
@azriel91 azriel91 force-pushed the feature/116/split-flow-params-and-item-spec-params branch from ec07f33 to d96ccf7 Compare April 16, 2023 22:30
@azriel91 azriel91 force-pushed the feature/116/split-flow-params-and-item-spec-params branch from 5416c8f to 4613964 Compare April 18, 2023 21:52
@azriel91 azriel91 force-pushed the feature/116/split-flow-params-and-item-spec-params branch from ac72ccd to 278319c Compare April 22, 2023 05:35
@azriel91 azriel91 marked this pull request as ready for review April 22, 2023 07:12
@azriel91 azriel91 merged commit 96ad55c into main Apr 22, 2023
@azriel91 azriel91 deleted the feature/116/split-flow-params-and-item-spec-params branch April 22, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split ItemSpecParams from FlowParams.
1 participant