-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split FlowParams
and ItemSpecParams
#117
Merged
azriel91
merged 41 commits into
main
from
feature/116/split-flow-params-and-item-spec-params
Apr 22, 2023
Merged
Split FlowParams
and ItemSpecParams
#117
azriel91
merged 41 commits into
main
from
feature/116/split-flow-params-and-item-spec-params
Apr 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
- Coverage 92.40% 91.94% -0.47%
==========================================
Files 277 288 +11
Lines 20981 22298 +1317
==========================================
+ Hits 19387 20501 +1114
- Misses 1594 1797 +203
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…and `apply_check` take in params.
azriel91
force-pushed
the
feature/116/split-flow-params-and-item-spec-params
branch
from
April 16, 2023 22:07
fcc82ba
to
ec07f33
Compare
azriel91
force-pushed
the
feature/116/split-flow-params-and-item-spec-params
branch
from
April 16, 2023 22:30
ec07f33
to
d96ccf7
Compare
azriel91
force-pushed
the
feature/116/split-flow-params-and-item-spec-params
branch
from
April 18, 2023 21:52
5416c8f
to
4613964
Compare
…ame field to `item_spec_params_provided`.
azriel91
force-pushed
the
feature/116/split-flow-params-and-item-spec-params
branch
from
April 22, 2023 05:35
ac72ccd
to
278319c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #116.