Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add peace::cfg:: prefix to id_newtype macro usages. #176

Merged
merged 6 commits into from
Jan 10, 2024

Conversation

azriel91
Copy link
Owner

@azriel91 azriel91 commented Jan 10, 2024

Closes #157.

Automatic fix of most imports:

cargo fix --workspace \
  --features "cli error_reporting output_progress" \
  --exclude peace_rt_model_web

The download example's wasm.rs was manually fixed.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (28bbde4) 93.39% compared to head (391f227) 93.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #176   +/-   ##
=======================================
  Coverage   93.39%   93.40%           
=======================================
  Files         408      408           
  Lines       41681    41690    +9     
=======================================
+ Hits        38930    38939    +9     
  Misses       2751     2751           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azriel91 azriel91 merged commit 47e4871 into main Jan 10, 2024
13 checks passed
@azriel91 azriel91 deleted the feature/157/id-newtype-macro-use-qualified-path branch January 10, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ItemId and other ID newtypes: Reference type by qualified path
1 participant