Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run state_diff_sh_cmd in ShCmdStateDiffFnSpec. #57

Merged
merged 15 commits into from
Dec 3, 2022

Conversation

azriel91
Copy link
Owner

Currently it runs state_desired_fn_spec, which is a bug.

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 92.69% // Head: 91.32% // Decreases project coverage by -1.36% ⚠️

Coverage data is based on head (b4b8982) compared to base (773674b).
Patch coverage: 90.36% of modified lines in pull request are covered.

❗ Current head b4b8982 differs from pull request most recent head 73be602. Consider uploading reports for the commit 73be602 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
- Coverage   92.69%   91.32%   -1.37%     
==========================================
  Files         127      144      +17     
  Lines        7199     7828     +629     
==========================================
+ Hits         6673     7149     +476     
- Misses        526      679     +153     
Impacted Files Coverage Δ
crate/rt_model_native/src/error.rs 50.00% <ø> (ø)
...m_specs/sh_cmd/src/sh_cmd_state_current_fn_spec.rs 80.00% <ø> (ø)
...m_specs/sh_cmd/src/sh_cmd_state_desired_fn_spec.rs 85.71% <ø> (ø)
workspace_tests/src/lib.rs 100.00% <ø> (ø)
item_specs/sh_cmd/src/sh_cmd_executor.rs 44.73% <42.30%> (ø)
item_specs/sh_cmd/src/sh_cmd.rs 50.00% <50.00%> (ø)
item_specs/sh_cmd/src/sh_cmd_ensure_op_spec.rs 66.66% <87.50%> (ø)
crate/rt_model/src/cmd_context_builder.rs 98.55% <88.23%> (-0.71%) ⬇️
item_specs/sh_cmd/src/sh_cmd_clean_op_spec.rs 64.40% <93.33%> (ø)
workspace_tests/src/item_specs/sh_cmd_item_spec.rs 94.34% <94.34%> (ø)
... and 42 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@azriel91 azriel91 force-pushed the bugfix/sh-cmd-item-spec branch from b4b8982 to 73be602 Compare December 2, 2022 23:59
@azriel91 azriel91 merged commit a05e272 into main Dec 3, 2022
@azriel91 azriel91 deleted the bugfix/sh-cmd-item-spec branch December 3, 2022 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant