Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework to use OctoKit in order to use paginate method #10

Merged
merged 4 commits into from
May 6, 2021
Merged

Rework to use OctoKit in order to use paginate method #10

merged 4 commits into from
May 6, 2021

Conversation

vbouchet31
Copy link
Collaborator

@vbouchet31 vbouchet31 commented Feb 4, 2021

Remove the dependency to GitHub library which has been replaced by OctoKit and use paginate method in order to get all the comments instead of the first X ones only.

@vbouchet31 vbouchet31 changed the title Fetch 100 comments by default instead of 30. Rework to use OctoKit in order to use paginate method Feb 5, 2021
Copy link
Owner

@azu azu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

LGTM without timeZone

src/Octokit.js Outdated Show resolved Hide resolved
@azu
Copy link
Owner

azu commented Feb 6, 2021

@vbouchet31 Thanks for your work!

However, I no longer use this tool.
If you are ok, I want to transfer this repository.
Also, Do you have npm account?

@vbouchet31
Copy link
Collaborator Author

Hi @azu . I don't have a npm account. It is my first contribution to a node project. However, given it is not a too visible and too sensitive tool, I am fine taking the risk of maintaining it if you wish. (I may regret this words later ;-) ).
I will create an account and let you know.

@vbouchet31
Copy link
Collaborator Author

@azu
Copy link
Owner

azu commented Feb 8, 2021

Nice! I've invited you to npm and this repo.

Now, you can do npm publish.

@azu
Copy link
Owner

azu commented Feb 8, 2021

After merging this PR, you can publish a new version to npm.

Updating Package

Almost Node.js project use semantic versioning.
This PR's change is "fixes".
So, you can use npm version patch command to update package's version.

After update the package's version, you can publish the new package to npm via npm publish command.

Commands:

# you need to login to npm first time
$ npm login
# update package.json
# Following command will do 1.2.2 → 1.2.3 and git tag
$ npm version patch
# publish to npm
$ npm publish

@vbouchet31 vbouchet31 merged commit 78aafc3 into azu:master May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants