bring NominalToIntegerTransformer in line with new testing setup #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limlam96
reviewed
Jul 1, 2024
limlam96
reviewed
Jul 2, 2024
Merged
limlam96
previously approved these changes
Jul 5, 2024
…e-with-new-testing-setup
…e-with-new-testing-setup
limlam96
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing #226
This seems to be the only transformer with an inverse_transform method. In this case I believe the coverage is adequate from existing tests and inherited tests from GenericTransformTests and GenericBaseNominalTransformerTests.