Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR @azure/arm-rediscache] redis: adding the missing notify-keyspace-events value #3654

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
750 changes: 376 additions & 374 deletions common/config/rush/pnpm-lock.yaml

Large diffs are not rendered by default.

9 changes: 8 additions & 1 deletion sdk/redis/arm-rediscache/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Release History

## 8.1.0 (2023-11-13)

**Features**

- Interface RedisCommonPropertiesRedisConfiguration has a new optional parameter notifyKeyspaceEvents


## 8.0.0 (2023-09-11)

**Features**
Expand Down Expand Up @@ -156,4 +163,4 @@ To understand the detail of the change, please refer to [Changelog](https://aka.

To migrate the existing applications to the latest version, please refer to [Migration Guide](https://aka.ms/js-track2-migration-guide).

To learn more, please refer to our documentation [Quick Start](https://aka.ms/azsdk/js/mgmt/quickstart ).
To learn more, please refer to our documentation [Quick Start](https://aka.ms/js-track2-quickstart).
8 changes: 4 additions & 4 deletions sdk/redis/arm-rediscache/_meta.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"commit": "6ef4a4ab04df6cea16702dd935ac036509e6bd12",
"commit": "4adcb2b975cb52edda643b92a5f9c72965350f01",
"readme": "specification/redis/resource-manager/readme.md",
"autorest_command": "autorest --version=3.9.7 --typescript --modelerfour.lenient-model-deduplication --azure-arm --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=D:\\Git\\azure-sdk-for-js ..\\azure-rest-api-specs\\specification\\redis\\resource-manager\\readme.md --use=@autorest/typescript@6.0.8 --generate-sample=true",
"autorest_command": "autorest --version=3.9.7 --typescript --modelerfour.lenient-model-deduplication --azure-arm --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/redis/resource-manager/readme.md --use=@autorest/typescript@^6.0.12",
"repository_url": "https://github.com/Azure/azure-rest-api-specs.git",
"release_tool": "@azure-tools/js-sdk-release-tools@2.7.2",
"use": "@autorest/typescript@6.0.8"
"release_tool": "@azure-tools/js-sdk-release-tools@2.7.4",
"use": "@autorest/typescript@^6.0.12"
}
23 changes: 8 additions & 15 deletions sdk/redis/arm-rediscache/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"sdk-type": "mgmt",
"author": "Microsoft Corporation",
"description": "A generated SDK for RedisManagementClient.",
"version": "8.0.0",
"version": "8.1.0",
"engines": {
"node": ">=18.0.0"
},
Expand Down Expand Up @@ -32,18 +32,19 @@
"mkdirp": "^2.1.2",
"typescript": "~5.2.0",
"uglify-js": "^3.4.9",
"rimraf": "^3.0.0",
"rimraf": "^5.0.0",
"dotenv": "^16.0.0",
"@azure/dev-tool": "^1.0.0",
"@azure/identity": "^3.3.0",
"@azure-tools/test-recorder": "^3.0.0",
"@azure-tools/test-credential": "^1.0.0",
"mocha": "^10.0.0",
"@types/mocha": "^10.0.0",
"esm": "^3.2.18",
"@types/chai": "^4.2.8",
"chai": "^4.2.0",
"cross-env": "^7.0.2",
"@types/node": "^18.0.0",
"@azure/dev-tool": "^1.0.0",
"@azure/arm-network": "^32.2.0",
"ts-node": "^10.0.0"
},
"repository": {
Expand Down Expand Up @@ -78,7 +79,7 @@
"extract-api": "api-extractor run --local",
"lint": "echo skipped",
"audit": "echo skipped",
"clean": "rimraf dist dist-browser dist-esm test-dist temp types *.tgz *.log",
"clean": "rimraf --glob dist dist-browser dist-esm test-dist temp types *.tgz *.log",
"build:node": "echo skipped",
"build:browser": "echo skipped",
"build:test": "echo skipped",
Expand Down Expand Up @@ -106,13 +107,5 @@
]
},
"autoPublish": true,
"homepage": "https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/redis/arm-rediscache",
"//sampleConfiguration": {
"productName": "",
"productSlugs": [
"azure"
],
"disableDocsMs": true,
"apiRefLink": "https://docs.microsoft.com/javascript/api/@azure/arm-rediscache?view=azure-node-preview"
}
}
"homepage": "https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/redis/arm-rediscache"
}
1 change: 1 addition & 0 deletions sdk/redis/arm-rediscache/review/arm-rediscache.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -701,6 +701,7 @@ export interface RedisCommonPropertiesRedisConfiguration {
maxmemoryDelta?: string;
maxmemoryPolicy?: string;
maxmemoryReserved?: string;
notifyKeyspaceEvents?: string;
readonly preferredDataArchiveAuthMethod?: string;
preferredDataPersistenceAuthMethod?: string;
rdbBackupEnabled?: string;
Expand Down
2 changes: 2 additions & 0 deletions sdk/redis/arm-rediscache/src/models/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,8 @@ export interface RedisCommonPropertiesRedisConfiguration {
* NOTE: This property will not be serialized. It can only be populated by the server.
*/
readonly maxclients?: string;
/** The keyspace events which should be monitored. */
notifyKeyspaceEvents?: string;
/**
* Preferred auth method to communicate to storage account used for data archive, specify SAS or ManagedIdentity, default value is SAS
* NOTE: This property will not be serialized. It can only be populated by the server.
Expand Down
6 changes: 6 additions & 0 deletions sdk/redis/arm-rediscache/src/models/mappers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -583,6 +583,12 @@ export const RedisCommonPropertiesRedisConfiguration: coreClient.CompositeMapper
name: "String"
}
},
notifyKeyspaceEvents: {
serializedName: "notify-keyspace-events",
type: {
name: "String"
}
},
preferredDataArchiveAuthMethod: {
serializedName: "preferred-data-archive-auth-method",
readOnly: true,
Expand Down
2 changes: 1 addition & 1 deletion sdk/redis/arm-rediscache/src/redisManagementClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export class RedisManagementClient extends coreClient.ServiceClient {
credential: credentials
};

const packageDetails = `azsdk-js-arm-rediscache/8.0.0`;
const packageDetails = `azsdk-js-arm-rediscache/8.1.0`;
const userAgentPrefix =
options.userAgentOptions && options.userAgentOptions.userAgentPrefix
? `${options.userAgentOptions.userAgentPrefix} ${packageDetails}`
Expand Down
43 changes: 43 additions & 0 deletions sdk/redis/arm-rediscache/test/sampleTest.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
/*
* Copyright (c) Microsoft Corporation.
* Licensed under the MIT License.
*
* Code generated by Microsoft (R) AutoRest Code Generator.
* Changes may cause incorrect behavior and will be lost if the code is regenerated.
*/

import {
Recorder,
RecorderStartOptions,
env
} from "@azure-tools/test-recorder";
import { assert } from "chai";
import { Context } from "mocha";

const replaceableVariables: Record<string, string> = {
AZURE_CLIENT_ID: "azure_client_id",
AZURE_CLIENT_SECRET: "azure_client_secret",
AZURE_TENANT_ID: "88888888-8888-8888-8888-888888888888",
SUBSCRIPTION_ID: "azure_subscription_id"
};

const recorderOptions: RecorderStartOptions = {
envSetupForPlayback: replaceableVariables
};

describe("My test", () => {
let recorder: Recorder;

beforeEach(async function(this: Context) {
recorder = new Recorder(this.currentTest);
await recorder.start(recorderOptions);
});

afterEach(async function() {
await recorder.stop();
});

it("sample test", async function() {
console.log("Hi, I'm a test!");
});
});
10 changes: 2 additions & 8 deletions sdk/redis/arm-rediscache/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,11 @@
],
"declaration": true,
"outDir": "./dist-esm",
"importHelpers": true,
"paths": {
"@azure/arm-rediscache": [
"./src/index"
]
}
"importHelpers": true
},
"include": [
"./src/**/*.ts",
"./test/**/*.ts",
"samples-dev/**/*.ts"
"./test/**/*.ts"
],
"exclude": [
"node_modules"
Expand Down