Skip to content

Commit

Permalink
fix code report issues (Azure#37657)
Browse files Browse the repository at this point in the history
Co-authored-by: Catalina Peralta <caperal@microsoft.com>
  • Loading branch information
catalinaperalta and cperaltah authored Nov 8, 2024
1 parent c6d4b95 commit 10bea08
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions scripts/breaking_changes_checker/detect_breaking_changes.py
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,8 @@ def get_parameter_type(annotation) -> str:
if isinstance(annotation, ast.Attribute):
return annotation.attr
if isinstance(annotation, ast.Constant):
if annotation.value is None:
return "None"
return annotation.value
if isinstance(annotation, ast.Subscript):
if isinstance(annotation.slice, tuple):
Expand Down Expand Up @@ -396,6 +398,7 @@ def create_class_report(cls: Type) -> Dict:
m = getattr(cls, method)
except AttributeError:
_LOGGER.info(f"Skipping method check for {method} on {cls}.")
continue

if inspect.isfunction(m) or inspect.ismethod(m):
if inspect.iscoroutinefunction(m):
Expand Down

0 comments on commit 10bea08

Please sign in to comment.