Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update victoryInEuropeDay.php #150

Closed
wants to merge 1 commit into from
Closed

Update victoryInEuropeDay.php #150

wants to merge 1 commit into from

Conversation

pioc92
Copy link
Contributor

@pioc92 pioc92 commented May 17, 2019

Fix official translation of victoryInEuropeDay
source : https://www.service-public.fr/particuliers/actualites/A13134

@stelgenhof stelgenhof self-requested a review May 17, 2019 12:10
stelgenhof
stelgenhof requested changes May 17, 2019
View reviewed changes
Copy link
Member

@stelgenhof stelgenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the corresponding unit test for this holiday. That is the reason why the CI build has failed.

@stelgenhof
Copy link
Member

Closing this PR as it is superseded by PR #153.

@stelgenhof stelgenhof closed this May 28, 2019
@stelgenhof stelgenhof added this to the v2.2.0 milestone Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stelgenhof stelgenhof stelgenhof requested changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pioc92 @stelgenhof