Swedish observance holidays #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c960657
force-pushed
the
sweden-observed
branch
2 times, most recently
from
053e8ab
to
236597d
Compare
c960657
force-pushed
the
sweden-observed
branch
from
236597d
to
af33694
Compare
|
I remember now that I was struggling how to categorize these. Perhaps OBSERVANCE is a better category indeed. |
stelgenhof
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to official holidays, Sweden has several de facto holidays and de facto half holidays (the term de facto is used in the English Wikipedia entry – I don't think a similar term is used in Swedish).
I think these de facto holidays should be marked as
TYPE_OBSERVANCE(same argument as for Good Friday in the Netherlands, as mentioned in #169 (comment)).I am not Swedish, so I don't have a deep understanding of this. But I previously marked these days as “real” public holidays on my website and received several comments from Swedes these days are not public holidays (helgdager).
This PR changes the type for Christmas Eve from
TYPE_OFFICIALtoTYPE_OBSERVANCE, and adds the two other de facto holidays and the three de facto half holidays (allTYPE_OBSERVANCE).