Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a new version of #124 (the previous version exploded in a giant conflict) that has been detangled from #123.
This PR adds support for fallback locales. This has two major purposes:
en_US
toen
introduces a kind of inheritance, so that strings shared between English variants are represented only once, while still allowing override for specific countries. This allows us to provide translations for all 102en_*
locales without repeating same same strings 102 times. This change makes the translation files less redundant, and we support a lot more locales.Regarding #2: I removed duplicate entries for existing translations (e.g. if
en_US
,en_GB
and all other variants were identical, I simply replaced them with oneen
entry). If there was a difference between e.g.de_DE
andde_AT
, I generally chose the larger country as the general translation (i.e. the translation forde_DE
becomesde
). This is somewhat arbitrary, but it can easily be changed later on without changing the currently supported locales (it only affects locales that are not currently supported).