Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working tests on php8 #238

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Working tests on php8 #238

merged 1 commit into from
Jan 12, 2021

Conversation

fezfez
Copy link
Contributor

@fezfez fezfez commented Nov 27, 2020

Tests are now working on php 8.

friendsofphp/php-cs-fixer is not compatible with php 8 so i have update deps via composer update --ignore-platform-reqs (why dont use phpcbf ?)

It will be nicer if github action could run the unit tests

@stelgenhof
Copy link
Member

Thanks for this! I haven't yet had the time to check with PHP8.

I haven't used phpcbf as I had some bad experience with tools automatically fixing code: introducing more issues than expected :).

As for github actions, already TravisCI and StyleCI are configured. Is there anything you see missing that Github Actions can do better?

Cheers! Sacha

@stelgenhof
Copy link
Member

@fezfez I'd like to merge your PR, however there are some issue with the code style. Can you reformat your code and commit again? Thanks!

@fezfez
Copy link
Contributor Author

fezfez commented Jan 12, 2021

@stelgenhof fixed ! :)

@stelgenhof stelgenhof added this to the 2.4 milestone Jan 12, 2021
@stelgenhof stelgenhof merged commit 648c901 into azuyalabs:develop Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants