-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS OOP Implementation #15
macOS OOP Implementation #15
Conversation
Hmm not sure what happened but I probably messed it up during fetch upstream from my editor. Co-authored-by: Thanh Phan <thanhph111@gmail.com>
So far what's working:
|
Thank you very much for taking the time to do this.
It's actually a bug, it has been fixed with 2a99d8c that I've just commited. Can you merge it again to have the update. |
…ste into oop-implementation
merge upstream
Yes I can confirm the files are saving correctly now, but still won't be pasted correctly(just one image in clipboard) as it will always return an error: e.g. , so now one of the ways to amend this is to see if files get saved(checking if file actually saved to the directory after running the command). What do you think? |
I can confirm now that all of the features are working normally now. |
Yeah,
|
Yeah I have tested it, the image still get correctly written to even though there's an error. |
Co-authored-by: Thanh Phan <thanhph111@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's really better now, I just have a few things to ask
It's a change that has been removed from the `main`. Also rename the variable and module to match the author's use case.
This fixes/amend issues in
darwin.py
that prevents the addon from functioning correctly on macOS:execute
function callsI also noted and fixed a typo in the preference panel, a missing space between
if
andthe
Other issues:
I also noticed that images gets written inside the .blend(which failed), is it the intended behavior? (The image doesn't get saved as the directory doesn't exist):
i.e. image.png being saved to
..filepath/project.blend/image.png
, as reported by the addonHowever the image do get saved correctly if it was saved to other directories, though it should be noted that saving an image with the osascript will always return an error(but still saves the file correctly), thus the image will not get pasted: