-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix non English filepath error in windows #21
Conversation
add suppport for different encoding system(For Example,'GBK') in Windows using local.getdefaultlocale() Now can import image like `测试图像.png` and not raise Index Error again.
And one more thing we should consider. On my machine, if we don't check this (in fact, users don't usually use it): the Blender will get an error:
because the import locale
locale.getdefaultlocale()
# ('en_GB', 'cp1252') Do you have any clue we can also solve that? |
I think the locale.getdefaultlocale()
# ('zh_CN', 'cp936')
locale.getdefaultlocale()
# after toggle,support non Chinese ('zh_CN', 'cp65001') May be we should set |
Yeah, you're right. But we should force it to |
Can you check that is OK on your side? |
Good, it works find. |
Great! I think we can have the merge now. The patch will be release this weekend. Thanks for your contributions! |
add suppport for different encoding system(For Example,'GBK') in Windows using local.getdefaultlocale()
Now can import image like
测试图像.png
and not raise Index Error again.Proposed changes
Screenshots/Screencasts
2021-10-01.02-47-53.mp4
Further comments