Support Windows with native PowerShell script and restructure code #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only work on PowerShell 5.1, which is preinstalled on Windows 10 version 1607 and up (until now - 21H2). From PowerShell 6, clipboard API works only with text. Although most Windows 10 computers today are code-compatible, need to take a stable approach in the future.
This loses the files' history, use `git log --follow` for more details.
The process is quite slow and the `Error: Not freed memory blocks` shows after closing 'Blender' (this is not the first time it appears, need to retest on 'PIL' to determine what causes this error).
The old path doesn't work if add-on folder name different from 'ImagePaste'. Also make the file name timestamp-based on Linux platform.
Merged
thanhph111
added a commit
that referenced
this pull request
Aug 6, 2021
- Ignore all files with extension `.blend`, `.blend1`, ..., `.blend32`. 'Blender' only supports 32 version files. - Ignore again `.pyd` files because we don't use 'Pillow' anymore (#8).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces Pillow library with PowerShell version 5.1 compatible scripts for Windows 10, which pre-installed from Windows 10 version 1607. This PR uses some features only supported by PowerShell version 5.1. From PowerShell version 6, the clipboard only works with text so this add-on won't work on machines that have no PowerShell 5.1.
This approach has 2 advantages:
I have also migrated the code to separate packages based on its support platform for ease of future maintenance.