Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better consistency in repo segments #105

Closed
wants to merge 1 commit into from
Closed

Better consistency in repo segments #105

wants to merge 1 commit into from

Conversation

SaswatPadhi
Copy link
Contributor

  • Added [g] and [s] to differentiate repos.
  • Removed separate colors for SVN (only repo colors would be used throughout)
  • Inside svn repo, it showed no segment. Now it shows delta and untracked count.

screenshot from 2013-11-02 20 15 09

@b-ryan
Copy link
Owner

b-ryan commented Nov 25, 2015

@SaswatPadhi I don't want to add the [s] and [g]. I don't want the [g] to clutter things up for the people that only ever use git, which is likely a large portion of this project's users. The SVN changes look valuable, but there are merge conflicts.

@b-ryan b-ryan mentioned this pull request Dec 27, 2015
Merged
amtrivedi91 added a commit to amtrivedi91/powerline-shell that referenced this pull request Aug 31, 2016
@amtrivedi91
Moved all repo stats code from git.py to the base
1378dbc 
When all of the new code to provide more interesting stats was added to
git.py, it was not very re-usable. A few pull requests could use it
though. In particular, b-ryan#105 adds more info to the svn segment and b-ryan#210
does the same for mercurial. I would rather not create inconsistencies
among these segments or have them duplicate code. Moving it into the
base file creates a place where each segment can access it and have a
consistent behavior.
amtrivedi91 added a commit to amtrivedi91/powerline-shell that referenced this pull request Aug 31, 2016
@amtrivedi91
Moved all repo stats code from git.py to the base
a4a1267 
When all of the new code to provide more interesting stats was added to
git.py, it was not very re-usable. A few pull requests could use it
though. In particular, b-ryan#105 adds more info to the svn segment and b-ryan#210
does the same for mercurial. I would rather not create inconsistencies
among these segments or have them duplicate code. Moving it into the
base file creates a place where each segment can access it and have a
consistent behavior.
@b-ryan b-ryan closed this in 7ad2bc2 Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SaswatPadhi @b-ryan