Fixes to get for python3 virtualenvs working #140
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been happily using powerline-shell on OSX for quite some time now. Thanks for building it.
I created a Python 3.4 virtualenv using Python3's builtin pyvenv command and powerline-shell would break anytime I activate it, powerline-shell would barf out. I decided to spend some time making things cross compatible between python2 (>= 2.6) and python3. It turned out to be far easier than I'd anticipated it to be.
I've been using this patched version for the past couple of days with Python 2.7 and Python 3.4. I found that this issue had been reported earlier on #118, but I couldn't find a way to attach a pull request against that issue. I've also got another branch with a few pep8 fixes on top of this, but that should probably be addressed separately.