Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not export PS1 and PROMPT_COMMAND #193

Merged
merged 1 commit into from
Jul 27, 2015
Merged

Do not export PS1 and PROMPT_COMMAND #193

merged 1 commit into from
Jul 27, 2015

Conversation

h3xx
Copy link
Contributor

@h3xx h3xx commented Jul 7, 2015

PS1 and PROMPT_COMMAND are never used outside of bash. There's never a
reason to export them into the environment variable arena.

PS1 and PROMPT_COMMAND are never used outside of bash. There's never a
reason to export them into the environment variable arena.
@blieque
Copy link

blieque commented Jul 17, 2015

What if someone launches a new instance of their shell from within the shell? I know it's an add thing to do, but someone may have a reason to; I know I've done it before. Without export the variables would not be passed into the new shell.

@h3xx
Copy link
Contributor Author

h3xx commented Jul 18, 2015

What if someone launches a new instance of their shell from within the shell?

When you type bash into a terminal running bash, it re-executes your .bashrc. If you put the PS1 setting in your .bashrc like the file says, it'll still work.

Source: I just tried it, after making sure PS1 wasn't in my environment.

@blieque
Copy link

blieque commented Jul 18, 2015

Very good point; I'll merge your changes into my fork.

b-ryan added a commit that referenced this pull request Jul 27, 2015
Do not export PS1 and PROMPT_COMMAND
@b-ryan b-ryan merged commit d3969f7 into b-ryan:master Jul 27, 2015
amtrivedi91 added a commit to amtrivedi91/powerline-shell that referenced this pull request Aug 31, 2016
Do not export PS1 and PROMPT_COMMAND
amtrivedi91 added a commit to amtrivedi91/powerline-shell that referenced this pull request Aug 31, 2016
Do not export PS1 and PROMPT_COMMAND
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants