svn: Update segment to ThreadedSegment #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-ryan
reviewed
Nov 27, 2017
powerline_shell/segments/svn.py
Outdated
| return | ||
| class Segment(ThreadedSegment): | ||
| def __init__(self, powerline): | ||
| super().__init__(powerline) |
There was a problem hiding this comment.
This project currently supports Python 2 and super() won't work there. Dropping python 2 has been something on my mind, but right now that's the situation.
There was a problem hiding this comment.
Does 2fba29e fix this?
|
LGTM. Did some basic testing, but I assume you were more thorough. Thanks! |
emansije
reviewed
Dec 15, 2017
|
|
||
| for line in svn_info.splitlines(): | ||
| line = line.decode("utf-8").strip() | ||
| if "Revision: " in line: |
There was a problem hiding this comment.
There's an issue with locales other than English because svn info's output is localized. I fixed it in commit 235e02b, since I had to merge it anyway. My solution was to use svn info --xml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modeled after the git segment.