Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SO-6106: "Sub...PropertyOf" support for axiom-relationship conversions #1289

Merged
merged 7 commits into from
May 8, 2024

Conversation

apeteri
Copy link
Member

@apeteri apeteri commented May 7, 2024

The pull request:

  • Updates the OWL Toolkit to version 3.0.106 from 3.0.6, with groupId change
  • Introduces a new Collection<Long> annotationAttributes parameter for the relationship-to-axiom converter
  • Allows SubAnnotationPropertyOf axioms to be converted into an IS A relationship fragment in the axiom-to-relationship converter

@apeteri apeteri requested review from cmark, nagyo and AAAlinaaa May 7, 2024 15:15
@apeteri apeteri self-assigned this May 7, 2024
@apeteri apeteri changed the title SO-6106: "Sub...PropertyOf" support for axiom <-> relationship conversions SO-6106: "Sub...PropertyOf" support for axiom-relationship conversions May 7, 2024
Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥓

Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@apeteri apeteri added the port-to-9.x Pull requests that need a complementary PR targeting the 9.x stream label May 7, 2024
@cmark cmark merged commit 4c7742b into 7.x May 8, 2024
0 of 2 checks passed
@cmark cmark deleted the feature/SO-6106-subproperty-of-support branch May 8, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement port-to-9.x Pull requests that need a complementary PR targeting the 9.x stream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants