Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locks): support timeout api parameter with a default value of 3s #1298

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

cmark
Copy link
Member

@cmark cmark commented Jun 7, 2024

No description provided.

@cmark cmark requested review from apeteri and nagyo June 7, 2024 13:43
@cmark cmark self-assigned this Jun 7, 2024
Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍏

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 48.46%. Comparing base (719d89b) to head (1ca067c).

Files Patch % Lines
...l/core/locks/request/LockChangeRequestBuilder.java 0.00% 4 Missing ⚠️
...ocks/request/ResourceLockChangeRequestBuilder.java 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                9.x    #1298   +/-   ##
=========================================
  Coverage     48.45%   48.46%           
- Complexity    13999    14000    +1     
=========================================
  Files          1947     1947           
  Lines         95190    95198    +8     
  Branches      11000    11000           
=========================================
+ Hits          46129    46134    +5     
- Misses        46037    46043    +6     
+ Partials       3024     3021    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍃

@cmark cmark merged commit d5c04d6 into 9.x Jun 10, 2024
5 checks passed
@cmark cmark deleted the issue/lock-api-timeout-parameter branch June 10, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants