Fix TypeScript definition errors #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current TypeScript definitions do not compile: > ../../node_modules/koa-easy-ws/index.d.ts(5,66): error TS2706: Required type parameters may not follow optional type parameters. > ../../node_modules/koa-easy-ws/index.d.ts(6,3): error TS1170: A computed property name in a type literal must refer to an expression whose type is a literal type or a 'unique symbol' type. > ../../node_modules/koa-easy-ws/index.d.ts(6,4): error TS2693: 'PropertyName' only refers to a type, but is being used as a value here. > ../../node_modules/koa-easy-ws/index.d.ts(7,3): error TS1170: A computed property name in a type literal must refer to an expression whose type is a literal type or a 'unique symbol' type. > ../../node_modules/koa-easy-ws/index.d.ts(7,4): error TS2693: 'ServerPropertyName' only refers to a type, but is being used as a value here. > ../../node_modules/koa-easy-ws/index.d.ts(14,64): error TS2706: Required type parameters may not follow optional type parameters. This change fixes all of these errors.
|
Heya, it seems that this library isn't actively maintained anymore. I decided to fork it and am planning to maintain it. I applied your fixes to the fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current TypeScript definitions do not compile:
This change fixes all of these errors.