fix: ensure dispose checks are performed before and after entering render lock

Author: egil

src/bunit.core/Rendering/TestRenderer.cs

@@ -113,6 +113,9 @@ public Task DispatchEventAsync(
 		// if the event contains associated data.
 		lock (renderTreeUpdateLock)
 		{
+			if (disposed)
+				throw new ObjectDisposedException(nameof(TestRenderer));
+
 			var result = Dispatcher.InvokeAsync(() =>
 			{
 				ResetUnhandledException();
@@ -190,10 +193,16 @@ public void DisposeComponents()
 	/// <inheritdoc/>
 	internal void SetDirectParameters(IRenderedFragmentBase renderedComponent, ParameterView parameters)
 	{
+		if (disposed)
+			throw new ObjectDisposedException(nameof(TestRenderer));
+
 		// Calling SetDirectParameters updates the render tree
 		// if the event contains associated data.
 		lock (renderTreeUpdateLock)
 		{
+			if (disposed)
+				throw new ObjectDisposedException(nameof(TestRenderer));
+
 			var result = Dispatcher.InvokeAsync(() =>
 			{
 				try
@@ -240,20 +249,20 @@ protected override void ProcessPendingRender()
 		// so there is no need to lock in that method.
 		lock (renderTreeUpdateLock)
 		{
+			if (disposed)
+			{
+				logger.LogRenderCycleActiveAfterDispose();
+				return;
+			}
+
 			base.ProcessPendingRender();
 		}
 	}
 
 	/// <inheritdoc/>
 	protected override Task UpdateDisplayAsync(in RenderBatch renderBatch)
 	{
-		if (disposed)
-		{
-			return Task.CompletedTask;
-		}
-
 		var renderEvent = new RenderEvent();
-
 		PrepareRenderEvent(renderBatch);
 		InvokeApplyRenderEvent();
 
@@ -394,10 +403,13 @@ protected override void Dispose(bool disposing)
 		if (disposed)
 			return;
 
-		disposed = true;
-
 		lock (renderTreeUpdateLock)
 		{
+			if (disposed)
+				return;
+
+			disposed = true;
+
 			if (disposing)
 			{
 				foreach (var rc in renderedComponents.Values)
@@ -467,6 +479,9 @@ private IReadOnlyList<IRenderedComponentBase<TComponent>> FindComponents<TCompon
 		// while this method searches through it.
 		lock (renderTreeUpdateLock)
 		{
+			if (disposed)
+				throw new ObjectDisposedException(nameof(TestRenderer));
+
 			FindComponentsInRenderTree(parentComponent.ComponentId);
 		}
 
@@ -579,11 +594,14 @@ private void AssertNoUnhandledExceptions()
 		// tests failing that should not be failing.
 		lock (renderTreeUpdateLock)
 		{
-			if (capturedUnhandledException is Exception unhandled && !disposed)
+			if (disposed)
+				return;
+
+			if (capturedUnhandledException is { } unhandled)
 			{
 				capturedUnhandledException = null;
 
-				if (unhandled is AggregateException aggregateException && aggregateException.InnerExceptions.Count == 1)
+				if (unhandled is AggregateException { InnerExceptions.Count: 1 } aggregateException)
 				{
 					ExceptionDispatchInfo.Capture(aggregateException.InnerExceptions[0]).Throw();
 				}