Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change all bUnit services registration from singleton to scoped #1150

Merged
merged 2 commits into from
Jul 7, 2023
Merged

fix: Change all bUnit services registration from singleton to scoped #1150

merged 2 commits into from
Jul 7, 2023

Conversation

egil
Copy link
Member

@egil egil commented Jul 7, 2023

#fixes #1138

@egil egil requested a review from linkdotnet July 7, 2023 18:27
linkdotnet
linkdotnet previously approved these changes Jul 7, 2023
View reviewed changes
Copy link
Sponsor Collaborator

@linkdotnet linkdotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity - did you ran the unit test in the docs for MSTest and NUnit? I don't expect any change, but curious nevertheless.

@egil
Copy link
Member Author

egil commented Jul 7, 2023

Just out of curiosity - did you ran the unit test in the docs for MSTest and NUnit? I don't expect any change, but curious nevertheless.

Good point. Been meaning to add test runs of the sample test to the verification workflow.

@linkdotnet
Copy link
Sponsor Collaborator

Just out of curiosity - did you ran the unit test in the docs for MSTest and NUnit? I don't expect any change, but curious nevertheless.

Good point. Been meaning to add test runs of the sample test to the verification workflow.

Good idea in general independent of the current issue! I like <3

@egil egil merged commit 0696817 into main Jul 7, 2023
4 checks passed
@egil egil deleted the 1138-scoped-services branch July 7, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linkdotnet linkdotnet linkdotnet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scoped IComponentActivator breaks bUnit
2 participants
@egil @linkdotnet