Skip to content

Add missing closing bracket in semantic-html-comparison.md #1707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

RichardPoes
Copy link
Contributor

Pull request description

Adds the character > to the documentation to close the HTML-tag.

PR meta checklist

  • Pull request is targeted at main branch for code
    or targeted at stable branch for documentation that is live on bunit.dev.
  • Pull request is linked to all related issues, if any.
  • I have read the CONTRIBUTING.md document.

Code PR specific checklist

  • My code follows the code style of this project and AspNetCore coding guidelines.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have updated the appropriate sub section in the CHANGELOG.md.
  • I have added, updated or removed tests to according to my changes.
    • All tests passed.

@RichardPoes
Copy link
Contributor Author

@dotnet-policy-service agree

@linkdotnet
Copy link
Collaborator

Hey @RichardPoes thank you very much for the contribution.
As this is only targeting the docs, stable should be the target branch of your PR. I will set this for you.

@linkdotnet linkdotnet changed the base branch from main to stable April 14, 2025 06:41
@linkdotnet linkdotnet changed the base branch from stable to main April 14, 2025 06:42
@linkdotnet
Copy link
Collaborator

Ah darn - there are already some commits on main that shouldn't go into stable. Therefore can you rebase / cherry-pick / approach-of-your-choice to have stable as your baseline branch?

@RichardPoes RichardPoes changed the base branch from main to stable April 14, 2025 06:53
@RichardPoes
Copy link
Contributor Author

Yes, done!

@linkdotnet
Copy link
Collaborator

Amazing! Thank you very much

@RichardPoes
Copy link
Contributor Author

It ain’t much but it’s honest work

@linkdotnet linkdotnet merged commit 1593725 into bUnit-dev:stable Apr 14, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants