Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next 9.3 Sass Modules #94

Merged
merged 11 commits into from
Mar 21, 2020
Merged

Next 9.3 Sass Modules #94

merged 11 commits into from
Mar 21, 2020

Conversation

Drapegnik
Copy link
Member

@Drapegnik Drapegnik commented Mar 10, 2020 •
edited by UladBohdan
Loading

refactor components to sass modules:

  • sidebar
  • footer
  • about
  • article
  • blocks
  • cards
  • tag
  • topic
  • login
  • admin
  • diary

@Drapegnik Drapegnik changed the title fix(*): temp Next 9.3 Sass Modules Mar 10, 2020
Drapegnik added a commit that referenced this pull request Mar 10, 2020
@Drapegnik
fix(tools): next@9.3, build in sass support [#94]
1fd0c04
Drapegnik added a commit that referenced this pull request Mar 10, 2020
@Drapegnik
style(core): rename to scss modules [#94]
8021c68
Drapegnik added a commit that referenced this pull request Mar 10, 2020
@Drapegnik
task(core): apply scss modules: sidebar, footer, about & article [#94]
0534637
@Drapegnik Drapegnik requested review from UladBohdan and andemerie and removed request for UladBohdan March 10, 2020 15:31
Drapegnik added a commit that referenced this pull request Mar 12, 2020
@Drapegnik
task(core): partly apply scss modules for blocks [#94]
b70dda9
Drapegnik
Drapegnik commented Mar 12, 2020
View reviewed changes
pages/_app.js Outdated Show resolved Hide resolved
Drapegnik added a commit that referenced this pull request Mar 12, 2020
@Drapegnik
task(core): import cards styles as global [#94]
ab3f571
Drapegnik added a commit that referenced this pull request Mar 12, 2020
@Drapegnik
task(core): apply scss modules: admin & login [#94]
e86d149
Drapegnik added a commit that referenced this pull request Mar 12, 2020
@Drapegnik
fix(core): remove legacy components [#94]
3c4bb2f
Drapegnik added a commit that referenced this pull request Mar 12, 2020
@Drapegnik
task(core): apply scss modules: diary, tag, topic & error pages [#94]
0faab5b
@Drapegnik Drapegnik marked this pull request as ready for review March 12, 2020 17:05
@Drapegnik
Copy link
Member Author

try next build-in sass support

Drapegnik added a commit that referenced this pull request Mar 14, 2020
@Drapegnik
fix(tools): next@9.3, build in sass support [#94]
e6eb799
Drapegnik added a commit that referenced this pull request Mar 14, 2020
@Drapegnik
style(core): rename to scss modules [#94]
d783437
Drapegnik added a commit that referenced this pull request Mar 14, 2020
@Drapegnik
task(core): apply scss modules: sidebar, footer, about & article [#94]
7e54974
@wirbot wirbot temporarily deployed to dev March 20, 2020 10:44 Inactive
@wirbot wirbot temporarily deployed to dev March 20, 2020 11:10 Inactive
Drapegnik
Drapegnik commented Mar 21, 2020
View reviewed changes
components/common/layout/header/Motto.js
@@ -18,7 +20,7 @@ const Motto = () => {

return (
<>
<span className="navbar__title--screen-wide">
<span className={styles['navbar__title--screen--wide']}>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't do it here without refactoring navbar stlyles

Drapegnik
Drapegnik commented Mar 21, 2020
View reviewed changes
utils/fibery/renderer.module.scss

$block-spacing: 60px;

.article-ordered {
Copy link
Member Author

@Drapegnik Drapegnik Mar 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are you think about: each class in this file - own module?

Copy link
Member

@UladBohdan UladBohdan Mar 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's either separate files or we can't use bem lib and stick to styles dict

@wirbot wirbot temporarily deployed to dev March 21, 2020 16:29 Inactive
@Drapegnik Drapegnik merged commit 01b0c12 into develop Mar 21, 2020
Drapegnik added a commit that referenced this pull request Mar 21, 2020
@Drapegnik
fix(tools): next@9.3, build in sass support [#94]
f4cff4f
Drapegnik added a commit that referenced this pull request Mar 21, 2020
@Drapegnik
style(core): rename to scss modules [#94]
c07ee49
Drapegnik added a commit that referenced this pull request Mar 21, 2020
@Drapegnik
task(core): apply scss modules: sidebar, footer, about & article [#94]
fda5715
Drapegnik added a commit that referenced this pull request Mar 21, 2020
@Drapegnik
task(core): partly apply scss modules for blocks [#94]
fc11dc7
Drapegnik added a commit that referenced this pull request Mar 21, 2020
@Drapegnik
task(core): import cards styles as global [#94]
2824473
Drapegnik added a commit that referenced this pull request Mar 21, 2020
@Drapegnik
task(core): apply scss modules: admin & login [#94]
0ea2647
Drapegnik added a commit that referenced this pull request Mar 21, 2020
@Drapegnik
fix(core): remove legacy components [#94]
d554212
Drapegnik added a commit that referenced this pull request Mar 21, 2020
@Drapegnik
task(core): apply scss modules: diary, tag, topic & error pages [#94]
2f64069
@Drapegnik Drapegnik deleted the next-9.3-sass-modules branch March 21, 2020 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UladBohdan UladBohdan UladBohdan left review comments

@andemerie andemerie Awaiting requested review from andemerie

Assignees

@UladBohdan UladBohdan

Labels
✨improvement 🌳refactor 💅styles ⚙️tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Drapegnik @UladBohdan @wirbot