This repository has been archived by the owner on Dec 9, 2020. It is now read-only.
Allow vanity imports for travis #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansiwy
approved these changes
Sep 5, 2017
jtsaito
pushed a commit
that referenced
this pull request
Nov 23, 2017
…pdate Update lightsail_instance.html.markdown
fmasuhr
pushed a commit
that referenced
this pull request
Apr 24, 2018
hi @nicksantamaria , thanks for the contribution and the helpful feedback on this PR.
fmasuhr
pushed a commit
that referenced
this pull request
Apr 24, 2018
basic create budget functionality [hashicorp#753] use human readable date format and descriptive field names [hashicorp#753] add cost filters to budget resource [hashicorp#753] delete budget on resource destroy [hashicorp#753] fix go vet errors update and read a aws budget from the resource handle read of non-existent budget gracefully employ functions to remove duplication and clarify intent reuse existing method for budget existence check Added documentation for aws_budget resource. (#1) hi @nicksantamaria , thanks for the contribution and the helpful feedback on this PR. support full set of budget costtypes use default for budget time period end check proper creation of budget time period enable use of budget name_prefix as alternative to budget name update defaults budget values and documentation dry up budget test configs create test budget with end date which is always in the future align max budget end date with aws api max employ naming convention of aws service + resource - this is so we can keep resources grouped pr feedback: (https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r172539673) align filename with service + resource naming pr feedback: (https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r172539673) remove un-needed verbosity in object definition pr feedback: (https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r172576462) remove deprecated call to Set in AWS budgets SDK PR Feedback: (https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r172561258) check for errors on budget read and obey demeter PR Feedback: (https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r172580699) flatten budget and checks uses separate function PR Feedback: (https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r172580699) swap use of Set for struct init with value PR Feedback: (https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r172561258) add cost_types attr to align with aws budget api PR Feedback: (https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r172566294) accurate documentation of budget resource PR Feedback: - https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r172568560 - https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r172569165 - https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r172577391 - https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r172569549 remove extraneous functions from budgets resource adhere function names in budgets to conventions inline test check rather than separate function PR Feedback: (https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r172570851) unmarshal costtypes as separate function configure optional account_id for budget - includes documentation updates for supported import changes PR Feedback: (https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r172560437) account_id in budget resource docs use inline schema definition for budgets budget PR Feedback: (https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r176823677) use aws string helper to create pointers PR Feedback: (https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r176824529) compute name and name prefix for budgets budget PR Feedback: (https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r176828112) emit warning when budget is not found PR Feedback: (https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r176828446) call read after create budgets budget PR Feedback: (https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r176824910) (https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r176825249) remove redundant call on resource delete PR Feedback: (https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r176825987) define budget name on create only PR Feedback: (https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r176827787) correct name for budgets budget tests PR Feedback: (https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r178949969) reorder test cases for budgets PR Feedback: (https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r178956591) align test config function names to convention PR Feedback: (https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r178956192) adjust documentations to match nameing convention reorder and remove dups from attributes in docs PR Feedback: (https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r178957219) remove custom flat budget test struct - in favor of budgets.Budget PR Feedback: (https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r178955760) apply naming convention to all test functions use resources list to cleanup test budgets PR Feedback: (https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r178953821) conform budgetdestroy signature to testdestroy rework function signature for exists check PR Feedback: (https://github.com/terraform-providers/terraform-provider-aws/pull/1879/files#r178951991)
jtsaito
pushed a commit
that referenced
this pull request
May 22, 2019
* Update sagemaker_endpoint_configuration not found message when reading resources * Update sagemaker_endpoint error when resource is NotFound * Fix ResourceNotFound to ValidationException
fmasuhr
pushed a commit
that referenced
this pull request
Aug 14, 2019
Update ecr_repository_policy.html.markdown
fmasuhr
pushed a commit
that referenced
this pull request
Mar 11, 2020
awendt
pushed a commit
that referenced
this pull request
Oct 22, 2020
* Implementation of resource new resource type for GuardDuty S3 Export (hashicorp#10920) * Added tests and documentation * Fixed test namings * Fixed linter issues and removed explicit import test case * Fixed HCL formatting in documentation * Fixed some namings and sidebar link * Update/refactor publishing destination (#1) * Merged latest master changes and resolved conflicts * Merged from Upstream master and squashed commits * Delete defaults.go * Removed changes from vendor subdirectory and synched with master. * Refactor GuardDuty to waiter pattern * Remove unused constant * Small refactor based on PR review * Add disappears test and refactor based on PR review * Refactor based on PR review * Refactor according to PR review * Additional fix wrt tf 0.12 Co-authored-by: Sebastian Häpe <Sebastian.Haepe@nordcloud.com> Co-authored-by: shaepe <44882151+shaepe@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.