This repository has been archived by the owner on Aug 18, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does away with the custom traverser, and instead adds correct node visitors to get accurate scopes (and references/definitions) for flow types. It's written for easy upstreaming into
eslint-scope
(see #438) if that becomes a thing. How? New node type visitors are added (look for//new
), and only node type visitors were overwritten (look for//override
) instead ofvisit*
functions. There's some copy/paste from escope in the overwritten methods to clearly show where the new flow type code must go (look for<custom></custom>
).TODO:
declare
(Correct scoping, especially withdeclare module
).