Add a shouldInjectPolyfill option to polyfill providers
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new API has the same goal as the include/exclude options
(for this reason, it will throw an error if you try to use both), but
both have some advantages that the other one doesn't have:
1) include/exclude are an array, so you can use them
in a static JSON file. Also, they might be easier to use.
2) shouldInjectPolyfill is a function, so it is more powerful: for
example, you could use it to store somewhere a list of all
the injected polyfill, or to throw an error if a specific
polyfill would be injected (maybe because it's too big and
you want to be sure that you don't rely on it)
|
For the people wondering about the issues closed by this PR in the babel/babel repository: we'll release this alongside with the next Babel release. |
21 tasks
|
@nicolo-ribaudo can you ping me when this is released to npm? do you mean next major, minor, or patch of |
|
@niftylettuce you can always watch "releases only" |
|
This has been released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new API has the same goal as the include/exclude options
(for this reason, it will throw an error if you try to use both), but
both have some advantages that the other one doesn't have:
in a static JSON file. Also, they might be easier to use.
example, you could use it to store somewhere a list of all
the injected polyfill, or to throw an error if a specific
polyfill would be injected (maybe because it's too big and
you want to be sure that you don't rely on it)
Fixes #10, fixes babel/babel#11583 (cc @niftylettuce), fixes babel/babel#6625, can fix babel/babel#8489