support node4 #16
Merged
support node4 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzoo
reviewed
Feb 21, 2018
package.json
Outdated
| @@ -22,6 +30,10 @@ | |||
| "write-pkg": "^3.1.0" | |||
| }, | |||
| "devDependencies": { | |||
| "@babel/cli": "^7.0.0-beta.40", | |||
| "@babel/core": "^7.0.0-beta.40", | |||
| "@babel/polyfill": "^7.0.0-beta.40", | |||
hiroppy
force-pushed
the
feature/support-node-4
branch
from
8823ad4 to
0c301d4
Compare
|
@hzoo Updated:) |
hiroppy
force-pushed
the
feature/support-node-4
branch
from
0c301d4 to
89057c8
Compare
|
Haha we need babel-core too right.. |
|
Yeah in order to know this actually works we need to add travis, so I did that ^, lets see |
|
Thanks for adding Travis;) |
|
finally.. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #13.
Make use of
@babel/preset-envand specify Node4.I do not think the name of
src/bin.jsis very good.So I want to change the name of
src/index.jsand renamesrc/bin.jstosrc/index.js.