Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add punctuation to traverseNeedsParent message. #3123

Merged
merged 1 commit into from
Dec 11, 2015

Conversation

jmm
Copy link
Member

@jmm jmm commented Dec 1, 2015

Is this how it's supposed to read? Saw it here and just thought it should be a => an, but then when I looked it up it seemed like it has a different meaning than I originally read it as.

Error: You must pass a scope and parentPath unless traversing a Program/File got a undefined node

@codecov-io
Copy link

Current coverage is 84.72%

Merging #3123 into master will decrease coverage by -0.28% as of 9674ef4

@@            master   #3123   diff @@
======================================
  Files          214     214       
  Stmts        15592   15592       
  Branches      3329    3329       
  Methods          0       0       
======================================
- Hit          13254   13211    -43
- Partial        690     733    +43
  Missed        1648    1648       

Review entire Coverage Diff as of 9674ef4

Powered by Codecov. Updated on successful CI builds.

@jamiebuilds
Copy link
Contributor

You could write a(n)?

@jmm
Copy link
Member Author

jmm commented Dec 2, 2015

@thejameskyle Thanks. What I mean is, with a or an or a(n) I think it doesn't say what it means. It reads like:

You must pass a scope and parentPath unless traversing a Program/File yielded a $1 node.

But I think it means this:

You must pass a scope and parentPath unless traversing a Program/File. Instead of that you tried to traverse a $1 node without passing scope and parentPath.

Or in other words:

You must pass a scope and parentPath unless traversing a Program/File. Got a $1 node.

(Though maybe ending that with instead would be better.)

Is that correct?

@jamiebuilds
Copy link
Contributor

Yeah it definitely means

You must pass a scope and parentPath unless traversing a Program/File. Instead of that you tried to traverse a $1 node without passing scope and parentPath.

I would just update it to say that

@jmm jmm force-pushed the traverse-needs-parent-message branch from fb2293c to 9674ef4 Compare December 11, 2015 14:51
jmm added a commit that referenced this pull request Dec 11, 2015
Make traverseNeedsParent message clearer.
@jmm jmm merged commit 740604f into babel:master Dec 11, 2015
@jmm
Copy link
Member Author

jmm commented Dec 11, 2015

@thejameskyle Thanks for the feedback! Updated it as suggested and merged.

@jmm jmm deleted the traverse-needs-parent-message branch January 19, 2016 22:19
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants