Remove jsx-self from react preset #3552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzoo
added
the
PR: Bug Fix 🐛
Current coverage is 87.91%@@ master #3552 diff @@
==========================================
Files 194 194
Lines 9638 9638
Methods 1100 1101 +1
Messages 0 0
Branches 2204 2203 -1
==========================================
Hits 8473 8473
Misses 1165 1165
Partials 0 0
|
|
Not sure yet what our story is but it shouldn't be having it here by default, at least not without a new major version of the preset. Thanks for the PR – lgtm. |
oliviertassinari
added a commit
to oliviertassinari/babel-plugin-transform-react-remove-prop-types
that referenced
this pull request
Jun 27, 2016
This was referenced Jul 28, 2016
Closed
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And I guess we could remove both packages from package.json too?
I didn't have much context in the plugin at the time, so everyone will have to opt-in to adding this then?
Ok I believe it's since the env defaults to development but the issue is that users don't always set the env to production.
@jimfb @spicyj