Use absolute paths in Babel's CONTRIBUTING.md #5431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
existentialism
added
the
PR: Docs 📝
|
Unrelated to this PR, but we should also fix the heading hierarchy (the headings under developing should be ### instead of ####) This would result in a cleaner nav on the website: vs.
|
existentialism
previously requested changes
Mar 8, 2017
CONTRIBUTING.md
Outdated
| @@ -3,15 +3,15 @@ | |||
| ---- | |||
|
|
|||
| <p align="center"> | |||
There was a problem hiding this comment.
Two things:
-
Let's add "toc" class to this, so we can hide these on the website, no sense in having TOC links here AND on the side.
-
Let's revert back to the anchor links, with these changes:
Codecov Report
@@ Coverage Diff @@
## 7.0 #5431 +/- ##
==========================================
- Coverage 85.43% 85.39% -0.05%
==========================================
Files 203 203
Lines 9532 9533 +1
Branches 2702 2703 +1
==========================================
- Hits 8144 8141 -3
- Misses 901 905 +4
Partials 487 487
Continue to review full report at Codecov.
|
existentialism
pushed a commit
that referenced
this pull request
Mar 13, 2017
hulkish
added a commit
to hulkish/babel
that referenced
this pull request
May 2, 2017
* 'master' of github.com:hulkish/babel: (37 commits) Increase the code coverage for traverse evaluation (babel#5363) Improve options documentation for `babel-plugin-transform-runtime` babel#5401 [doc] Fix: comments in usage w/ options babel#5400 document cache option for babel-register babel#5440 Update coffescript/register reference link address babel#5475 Update babel-generator's README babel#5517 Improve example of babel-plugin-transform-es2015-arrow-functions babel#5573 Remove incorrect docs. babel#5580 Update transform-es2015-modules-commonjs doc babel#5588 Fix replacing function declaration in export default (fixes babel#4468) (babel#5456) Fix a typo: occurences -> occurrences (babel#5575) Fix changelog [skip ci] Treat "await" as an invalid identifier (babel#4954) Removes unused lodash dependency from babel-helper-builder-react-jsx (babel#5486) docs: [skip ci] update documentation v6.24.0 changelog for 6.24.0 [skip ci] (babel#5452) Keep parentheses for logical expression when in await expression (fix babel#5428) (babel#5433) (babel#5453) Use absolute paths in Babel's CONTRIBUTING.md (babel#5431) Fixed broken links in README.md [skip ci] (babel#5449) ...
existentialism
pushed a commit
that referenced
this pull request
May 19, 2017
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing relative paths to absolute paths such that babel/website#1192
LinkCheckwill pass. This also ensures that links will work on the Babel website.